From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Brian Foster <bfoster@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3 0/3] xfs: test malformed inode mode
Date: Fri, 20 Jan 2017 13:25:50 +0800 [thread overview]
Message-ID: <20170120052550.GV1859@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1483968625-29160-1-git-send-email-amir73il@gmail.com>
Hi,
On Mon, Jan 09, 2017 at 03:30:22PM +0200, Amir Goldstein wrote:
> Eryu,
>
> This is the 3rd revision of the malformed inode mode test.
>
> Like with v2, patch 1 is safe and it passes on kernel 4.9.
>
> Like with v2, patch 2 is safe, but unlike v2, it fails on
> kernel 4.9, because I added a stronger expectation for the
> test to fails on stat of directory with inode size 0.
>
> Like with v2, patch 3 triggers an XFS assert and I removed
> the "safety pin" that was there in v2.
>
> I already sent the fix patch to Darick, which addresses the
> failures in both patch 2 and 3.
>
> You could merge patch 1 now and defer merging patches 2-3
> or you could wait with merging the entire test. up to you.
I'll merge patch 2-3 in this week update, Darrick has sent the fixes to
Linus, hopefully they'll be in rc5 next week.
Thanks,
Eryu
prev parent reply other threads:[~2017-01-20 5:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 13:30 [PATCH v3 0/3] xfs: test malformed inode mode Amir Goldstein
2017-01-09 13:30 ` [PATCH v3 1/3] xfs: test handling of invalid inode modes Amir Goldstein
2017-01-09 13:36 ` Amir Goldstein
2017-01-09 13:39 ` Amir Goldstein
2017-01-09 13:30 ` [PATCH v3 2/3] xfs: test fstat with malformed inode mode Amir Goldstein
2017-01-09 13:30 ` [PATCH v3 3/3] xfs: test readlink/readdir " Amir Goldstein
2017-01-11 6:38 ` Amir Goldstein
2017-01-11 6:41 ` Amir Goldstein
2017-01-20 5:25 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120052550.GV1859@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).