From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: xfs/122 failure for a while
Date: Tue, 24 Jan 2017 09:02:10 -0800 [thread overview]
Message-ID: <20170124170210.GA9134@birch.djwong.org> (raw)
In-Reply-To: <20170124094054.GA8536@infradead.org>
On Tue, Jan 24, 2017 at 01:40:54AM -0800, Christoph Hellwig wrote:
> xfs/122 has been failing for me for a while with this error:
>
> -sizeof(xfs_dsb_t) = 272
> +sizeof(xfs_dsb_t) = 264
>
> That 272 numbers comes from:
>
> 908ce96f ("xfs/122: add the realtime rmapbt inode and btree fields"),
> which don't seem to be features that made it into the kernel and
> xfsprogs so far.
Yeah... the realtime rmapbt tests got sucked into xfstests back when I
thought we were closer to landing that feature. Then I decided to let
it sit on the backburner behind online scrub so that the disk format
could stay the same for longer.
I've wondered for a while if it would make sense to special-case
xfs_dsb_t not to complain about a smaller value (because if features
start falling off the kernel you're likely to notice) but arranging
the parsing for all that made my head hurt.
For now I'll just set it back to 264.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-01-24 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 9:40 xfs/122 failure for a while Christoph Hellwig
2017-01-24 17:02 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124170210.GA9134@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).