* [PATCH] xfs/122: reduce xfs_dsb_t size
@ 2017-01-24 17:08 Darrick J. Wong
2017-01-24 17:09 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2017-01-24 17:08 UTC (permalink / raw)
To: Eryu Guan; +Cc: Christoph Hellwig, linux-xfs, fstests
We're not going to do reverse-mapping on the realtime device for
some time, so let's fix xfs/122 in the meantime.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/122.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/122.out b/tests/xfs/122.out
index 67f7698..168cfd5 100644
--- a/tests/xfs/122.out
+++ b/tests/xfs/122.out
@@ -138,7 +138,7 @@ sizeof(xfs_dir2_sf_off_t) = 2
sizeof(xfs_disk_dquot_t) = 104
sizeof(xfs_dq_logformat_t) = 24
sizeof(xfs_dqblk_t) = 136
-sizeof(xfs_dsb_t) = 272
+sizeof(xfs_dsb_t) = 264
sizeof(xfs_efd_log_format_32_t) = 28
sizeof(xfs_efd_log_format_64_t) = 32
sizeof(xfs_efi_log_format_32_t) = 28
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs/122: reduce xfs_dsb_t size
2017-01-24 17:08 [PATCH] xfs/122: reduce xfs_dsb_t size Darrick J. Wong
@ 2017-01-24 17:09 ` Christoph Hellwig
2017-01-24 17:11 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2017-01-24 17:09 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eryu Guan, Christoph Hellwig, linux-xfs, fstests
On Tue, Jan 24, 2017 at 09:08:19AM -0800, Darrick J. Wong wrote:
> We're not going to do reverse-mapping on the realtime device for
> some time, so let's fix xfs/122 in the meantime.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs/122: reduce xfs_dsb_t size
2017-01-24 17:09 ` Christoph Hellwig
@ 2017-01-24 17:11 ` Eric Sandeen
2017-01-24 17:30 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2017-01-24 17:11 UTC (permalink / raw)
To: Christoph Hellwig, Darrick J. Wong; +Cc: Eryu Guan, linux-xfs, fstests
On 1/24/17 11:09 AM, Christoph Hellwig wrote:
> On Tue, Jan 24, 2017 at 09:08:19AM -0800, Darrick J. Wong wrote:
>> We're not going to do reverse-mapping on the realtime device for
>> some time, so let's fix xfs/122 in the meantime.
>>
>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Looks fine,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Philosophically (I'm good at that) how do we handle tests like this
that really only work on the latest version of the code, but don't
actually indicate a bug if it fails on something older?
-Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs/122: reduce xfs_dsb_t size
2017-01-24 17:11 ` Eric Sandeen
@ 2017-01-24 17:30 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-01-24 17:30 UTC (permalink / raw)
To: Eric Sandeen
Cc: Christoph Hellwig, Darrick J. Wong, Eryu Guan, linux-xfs, fstests
On Tue, Jan 24, 2017 at 11:11:35AM -0600, Eric Sandeen wrote:
> Philosophically (I'm good at that) how do we handle tests like this
> that really only work on the latest version of the code, but don't
> actually indicate a bug if it fails on something older?
That might be another argument for doing the smaller than check that
Darrick suggested. Or an argument for simply stopping to check xfs_dsb,
it's growing constantly. Checking the offsets of known fields IFF
present wold seem more useful.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-24 17:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-24 17:08 [PATCH] xfs/122: reduce xfs_dsb_t size Darrick J. Wong
2017-01-24 17:09 ` Christoph Hellwig
2017-01-24 17:11 ` Eric Sandeen
2017-01-24 17:30 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).