From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eryu Guan <eguan@redhat.com>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/122: reduce xfs_dsb_t size
Date: Tue, 24 Jan 2017 09:30:27 -0800 [thread overview]
Message-ID: <20170124173027.GA30053@infradead.org> (raw)
In-Reply-To: <cc480f83-5d14-fbeb-f56d-be4dbd002b01@sandeen.net>
On Tue, Jan 24, 2017 at 11:11:35AM -0600, Eric Sandeen wrote:
> Philosophically (I'm good at that) how do we handle tests like this
> that really only work on the latest version of the code, but don't
> actually indicate a bug if it fails on something older?
That might be another argument for doing the smaller than check that
Darrick suggested. Or an argument for simply stopping to check xfs_dsb,
it's growing constantly. Checking the offsets of known fields IFF
present wold seem more useful.
prev parent reply other threads:[~2017-01-24 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 17:08 [PATCH] xfs/122: reduce xfs_dsb_t size Darrick J. Wong
2017-01-24 17:09 ` Christoph Hellwig
2017-01-24 17:11 ` Eric Sandeen
2017-01-24 17:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124173027.GA30053@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).