From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
bfoster@redhat.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: use per-AG reservations for the finobt
Date: Wed, 25 Jan 2017 10:13:51 +0100 [thread overview]
Message-ID: <20170125091351.GA16307@lst.de> (raw)
In-Reply-To: <20170124204257.GB5726@birch.djwong.org>
On Tue, Jan 24, 2017 at 12:42:57PM -0800, Darrick J. Wong wrote:
> > + if (error) {
> > + /*
> > + * Because we didn't have per-AG reservations when the
> > + * finobt feature was added we might not ne able to
> > + * reservere all needed blocks. Warn and fall back to
>
> "...might not be able to reserve all..."
Fixed.
> So if __xfs_ag_resv_init() returns ENOSPC, we don't actually halt the
> mount attempt, which means that we can start operating with
> mp->m_inotbt_nores = false if there's not even enough space for the
> refcountbt-only reservation. In theory this is impossible, but I think
> we'd be in a better defensive position by moving this to before the
> __xfs_ag_resv_init call.
Ok.
> > xfs_agnumber_t agno, struct xfs_buf **bpp);
> >
> > -
> > #endif /* __XFS_IALLOC_H__ */
>
> Unnecessary change?
Fixed.
next prev parent reply other threads:[~2017-01-25 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 20:16 avoid running out of space during finobt insertation Christoph Hellwig
2017-01-24 20:16 ` [PATCH 1/2] xfs: only update mount/resv fields on success in __xfs_ag_resv_init Christoph Hellwig
2017-01-24 20:33 ` Darrick J. Wong
2017-01-24 20:16 ` [PATCH 2/2] xfs: use per-AG reservations for the finobt Christoph Hellwig
2017-01-24 20:42 ` Darrick J. Wong
2017-01-25 9:13 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-25 9:14 avoid running out of space during finobt insertation Christoph Hellwig
2017-01-25 9:14 ` [PATCH 2/2] xfs: use per-AG reservations for the finobt Christoph Hellwig
2017-01-25 15:58 ` Darrick J. Wong
2017-01-27 5:08 ` Eric Sandeen
2017-01-27 14:59 ` Christoph Hellwig
2017-01-27 15:43 ` Eric Sandeen
2017-01-27 17:26 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125091351.GA16307@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).