From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: dave.hansen@linux.intel.com, mawilcox@microsoft.com,
linux-nvdimm@ml01.01.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, vbabka@suse.cz, jack@suse.com,
dan.j.williams@intel.com, linux-ext4@vger.kernel.org,
ross.zwisler@linux.intel.com, kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v2 2/3] mm, x86: Add support for PUD-sized transparent hugepages
Date: Thu, 26 Jan 2017 14:38:54 -0800 [thread overview]
Message-ID: <20170126143854.9694811975f4c0945aba58b9@linux-foundation.org> (raw)
In-Reply-To: <148545059381.17912.8602162635537598445.stgit@djiang5-desk3.ch.intel.com>
On Thu, 26 Jan 2017 10:09:53 -0700 Dave Jiang <dave.jiang@intel.com> wrote:
> The current transparent hugepage code only supports PMDs. This patch
> adds support for transparent use of PUDs with DAX. It does not include
> support for anonymous pages. x86 support code also added.
>
> Most of this patch simply parallels the work that was done for huge PMDs.
> The only major difference is how the new ->pud_entry method in mm_walk
> works. The ->pmd_entry method replaces the ->pte_entry method, whereas
> the ->pud_entry method works along with either ->pmd_entry or ->pte_entry.
> The pagewalk code takes care of locking the PUD before calling ->pud_walk,
> so handlers do not need to worry whether the PUD is stable.
The patch adds a lot of new BUG()s and BG_ON()s. We'll get in trouble
if any of those triggers. Please recheck everything and decide if we
really really need them. It's far better to drop a WARN and to back
out and recover in some fashion.
next prev parent reply other threads:[~2017-01-26 22:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 17:09 [PATCH v2 0/3] 1G transparent hugepage support for device dax Dave Jiang
2017-01-26 17:09 ` [PATCH v2 1/3] mm,fs,dax: Change ->pmd_fault to ->huge_fault Dave Jiang
2017-01-30 21:52 ` [PATCH] ext4: Remove unused function ext4_dax_huge_fault() Ross Zwisler
2017-01-30 23:43 ` [PATCH v2 1/3] mm,fs,dax: Change ->pmd_fault to ->huge_fault Ross Zwisler
2017-01-31 0:15 ` Dave Jiang
2017-01-26 17:09 ` [PATCH v2 2/3] mm, x86: Add support for PUD-sized transparent hugepages Dave Jiang
2017-01-26 22:38 ` Andrew Morton [this message]
2017-01-26 22:46 ` Dave Jiang
2017-01-26 17:10 ` [PATCH v2 3/3] dax: Support for transparent PUD pages for device DAX Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126143854.9694811975f4c0945aba58b9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=jack@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).