Re: [PATCH 5/9] common/fuzzy: move fuzzing helper functions here

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Fri, Jan 27, 2017 at 04:12:11PM +0800, Eryu Guan wrote:
> On Sat, Jan 21, 2017 at 12:10:50AM -0800, Darrick J. Wong wrote:
> > Move some fuzzing helper functions into a new common/fuzzy file.
> > We'll add a lot more fuzzing helpers in subsequent patches.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  common/fuzzy    |   80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  common/populate |   35 ------------------------
> >  tests/ext4/006  |    1 +
> >  tests/xfs/083   |    1 +
> >  4 files changed, 82 insertions(+), 35 deletions(-)
> >  create mode 100644 common/fuzzy
> > 
> > 
> > diff --git a/common/fuzzy b/common/fuzzy
> > new file mode 100644
> > index 0000000..d4f8274
> > --- /dev/null
> > +++ b/common/fuzzy
> > @@ -0,0 +1,80 @@
> ...
> > +# Try to access files after fuzzing
> > +_scratch_fuzz_test() {
> > +	echo "+++ ls -laR" >> $seqres.full
> > +	ls -laR "${SCRATCH_MNT}/test.1/" >/dev/null 2>&1
> > +
> > +	echo "+++ cat files" >> $seqres.full
> > +	(find "${SCRATCH_MNT}/test.1/" -type f -size -1048576k -print0 | xargs -0 cat) >/dev/null 2>&1
> > +}
> > +
> > +# Do we have an online scrub program?
> > +_require_scrub() {
> > +	case "${FSTYP}" in
> > +	"xfs"|"ext4")
> > +		test -x $XFS_SCRUB_PROG || _notrun "xfs_scrub not found"
> 
> In my release testing I found ext4/023 (moved from ext4/1300) failed due
> to lack of xfs_scrub, because "test -x " returns true, (but "test -x ''"
> doesn't), so I add quotes around $XFS_SCRUB_PROG and fold the update
> into this patch.

Oops!  Thanks for fixing this.

--D

> 
> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html