From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <sandeen@sandeen.net>,
linux-xfs <linux-xfs@vger.kernel.org>,
dm-devel@redhat.com
Subject: Re: error propagation problem on xfs over dm stripe
Date: Wed, 1 Feb 2017 06:49:35 -0800 [thread overview]
Message-ID: <20170201144935.GB27071@infradead.org> (raw)
In-Reply-To: <20170201143351.GA18848@redhat.com>
On Wed, Feb 01, 2017 at 09:33:51AM -0500, Mike Snitzer wrote:
> > FYI, what we do both in the XFS buffer cache and the new direct I/O
> > code is to use a
> >
> > cmpxchg(&dio->error, 0, ret);
> >
> > in a similar situation, which should work here, too.
>
> What is the benefit? Faster than the conditional?
In the cases where I added the code the concern is that multiple
bio completions could race updating the flag, cmpxchg is a good
protection against that. I'll need to take a look at the dm
case Eric reported in more detail to comment on it, though.
next prev parent reply other threads:[~2017-02-01 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 3:12 error propagation problem on xfs over dm stripe Eric Sandeen
2017-02-01 7:42 ` [dm-devel] " Christoph Hellwig
2017-02-01 14:33 ` Mike Snitzer
2017-02-01 14:49 ` Christoph Hellwig [this message]
2017-02-01 10:28 ` [dm-devel] " Junichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201144935.GB27071@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).