From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: update ctime and mtime on clone destinatation inodes
Date: Thu, 2 Feb 2017 18:47:23 +0100 [thread overview]
Message-ID: <20170202174723.GA7760@lst.de> (raw)
In-Reply-To: <20170202174547.GN9134@birch.djwong.org>
On Thu, Feb 02, 2017 at 09:45:47AM -0800, Darrick J. Wong wrote:
> On Thu, Feb 02, 2017 at 05:24:56PM +0100, Christoph Hellwig wrote:
> > We're changing both metadata and data, so we need to update the
> > timestamps. This follows existing btrfs behavior.
>
> /me wonders, should the mtime change if we're deduping? We're
> definitely changing metadata, but we shouldn't be making any
> user-visible changes to the file data.
Good point - we're hitting this from the dedup path as well.
I think we should not be updating mtime for dedupe.
next prev parent reply other threads:[~2017-02-02 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 16:24 [PATCH] xfs: update ctime and mtime on clone destinatation inodes Christoph Hellwig
2017-02-02 17:45 ` Darrick J. Wong
2017-02-02 17:47 ` Christoph Hellwig [this message]
2017-02-02 19:33 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202174723.GA7760@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox