From: Eryu Guan <eguan@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs/263: don't hardcode inode numbers in output
Date: Fri, 3 Feb 2017 14:42:30 +0800 [thread overview]
Message-ID: <20170203064230.GA1859@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170128203012.GQ14033@birch.djwong.org>
On Sat, Jan 28, 2017 at 12:30:12PM -0800, Darrick J. Wong wrote:
> On Sat, Jan 28, 2017 at 12:10:56PM -0600, Eric Sandeen wrote:
> > On 1/28/17 11:38 AM, Darrick J. Wong wrote:
> > > From: Darrick J. Wong <darrick.wong@oracle.com>
> > >
> > > Since we can't control the inode number assignments when creating files,
> > > don't hardcode them in the golden output.
> >
> > what numbers are you seeing?
> >
> > The inode numbers aren't important for the test, but I don't want to
> > gloss over something unexpected.
>
> I consistently see 131+64 = 195 and things like that.
I occasionally see 195/6 inode numbers too, I suspect it has something
to do with 4k-sector disks. Test failed if I point SCRATCH_DEV to a
4k-sector scsi_debug device, and test passed after applying this patch.
Thanks,
Eryu
next prev parent reply other threads:[~2017-02-03 6:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 17:38 [PATCH 1/3] xfs/263: don't hardcode inode numbers in output Darrick J. Wong
2017-01-28 17:38 ` [PATCH 2/3] xfs/299: don't chmod the underlying mountpoints prior to mounting Darrick J. Wong
2017-01-28 17:38 ` [PATCH 3/3] xfs/030: ignore lost rmapbt blocks Darrick J. Wong
2017-01-28 18:10 ` [PATCH 1/3] xfs/263: don't hardcode inode numbers in output Eric Sandeen
2017-01-28 20:30 ` Darrick J. Wong
2017-02-03 6:42 ` Eryu Guan [this message]
2017-02-03 17:46 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203064230.GA1859@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).