From: Brian Foster <bfoster@redhat.com>
To: Hou Tao <houtao1@huawei.com>
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
cmaiolino@redhat.com, sandeen@redhat.com
Subject: Re: [PATCH] xfs: reset b_first_retry_time when clear the retry status of xfs_buf_t
Date: Fri, 3 Feb 2017 08:06:53 -0500 [thread overview]
Message-ID: <20170203130653.GA45388@bfoster.bfoster> (raw)
In-Reply-To: <1486112905-38025-1-git-send-email-houtao1@huawei.com>
On Fri, Feb 03, 2017 at 05:08:25PM +0800, Hou Tao wrote:
> After successful IO or permanent error, b_first_retry_time also
> needs to be cleared, else the invalid first retry time will be
> used by the next retry check.
>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_buf_item.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c
> index 2975cb2..0306168 100644
> --- a/fs/xfs/xfs_buf_item.c
> +++ b/fs/xfs/xfs_buf_item.c
> @@ -1162,6 +1162,7 @@ xfs_buf_iodone_callbacks(
> */
> bp->b_last_error = 0;
> bp->b_retries = 0;
> + bp->b_first_retry_time = 0;
>
> xfs_buf_do_callbacks(bp);
> bp->b_fspriv = NULL;
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-03 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:08 [PATCH] xfs: reset b_first_retry_time when clear the retry status of xfs_buf_t Hou Tao
2017-02-03 13:06 ` Brian Foster [this message]
2017-02-03 20:32 ` Darrick J. Wong
2017-02-03 22:36 ` Dave Chinner
2017-02-03 23:18 ` Darrick J. Wong
2017-02-03 23:17 ` Darrick J. Wong
2017-02-04 1:38 ` Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203130653.GA45388@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox