From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, amir73il@gmail.com
Subject: Re: [PATCH v2] xfs: update ctime and mtime on clone destinatation inodes
Date: Fri, 3 Feb 2017 21:13:42 +0100 [thread overview]
Message-ID: <20170203201342.GA8047@lst.de> (raw)
In-Reply-To: <20170203174541.GS9134@birch.djwong.org>
On Fri, Feb 03, 2017 at 09:45:41AM -0800, Darrick J. Wong wrote:
> Redundant is_dedupe tests here.
>
> I also wonder if we really /want/ to emulate the existing btrfs
> behavior, which seems to be:
>
> reflink: update mtime & ctime
> dedupe: do not update mtime or ctime
>
> In particular, dedupe changes the inode metadata, which should qualify
> for a ctime update, right?
That depends on your metadata definition. For Posix it's basically just
about stat data, and that doesn't change with dedupe.
prev parent reply other threads:[~2017-02-03 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:57 [PATCH v2] xfs: update ctime and mtime on clone destinatation inodes Christoph Hellwig
2017-02-03 17:45 ` Darrick J. Wong
2017-02-03 18:08 ` Darrick J. Wong
2017-02-03 19:50 ` Amir Goldstein
2017-02-03 20:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203201342.GA8047@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).