From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/4] xfs: allocate direct I/O COW blocks in iomap_begin
Date: Sun, 5 Feb 2017 21:13:53 +0100 [thread overview]
Message-ID: <20170205201353.GA12914@lst.de> (raw)
In-Reply-To: <20170203105359.GA30020@lst.de>
On Fri, Feb 03, 2017 at 11:53:59AM +0100, Christoph Hellwig wrote:
> > I think this is incorrect -- we create an unwritten extent in the cow
> > fork above (BMAP_COWFORK | BMAP_PREALLOC) but we no longer convert the
> > part we're actually writing to a real extent. This means that
> > _reflink_cow won't actually remap anything that we've written.
>
> It's not correct and I messed up when rebasing - the version I tested
> still had it and worked. Sigh..
Or rather I hadn't finished rebasing and the version I had was totally
b0rked. Proper one in progress now..
next prev parent reply other threads:[~2017-02-05 20:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 21:42 reflink direct I/O improvements V2 Christoph Hellwig
2017-02-01 21:42 ` [PATCH 1/4] xfs: reject all unaligned direct writes to reflinked files Christoph Hellwig
2017-02-02 23:01 ` Darrick J. Wong
2017-02-01 21:42 ` [PATCH 2/4] xfs: introduce xfs_aligned_fsb_count Christoph Hellwig
2017-02-02 22:56 ` Darrick J. Wong
2017-02-01 21:42 ` [PATCH 3/4] xfs: go straight to real allocations for direct I/O COW writes Christoph Hellwig
2017-02-01 21:42 ` [PATCH 4/4] xfs: allocate direct I/O COW blocks in iomap_begin Christoph Hellwig
2017-02-03 0:55 ` Darrick J. Wong
2017-02-03 10:53 ` Christoph Hellwig
2017-02-05 20:13 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-06 7:47 reflink direct I/O improvements V3 Christoph Hellwig
2017-02-06 7:47 ` [PATCH 4/4] xfs: allocate direct I/O COW blocks in iomap_begin Christoph Hellwig
2017-02-07 1:41 ` Darrick J. Wong
2017-02-09 7:21 ` Christoph Hellwig
2017-02-09 7:53 ` Darrick J. Wong
2017-02-09 7:58 ` Christoph Hellwig
2017-02-09 8:00 ` Christoph Hellwig
2017-02-09 17:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170205201353.GA12914@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).