From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:40251 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbdBFPYE (ORCPT ); Mon, 6 Feb 2017 10:24:04 -0500 Date: Mon, 6 Feb 2017 07:24:00 -0800 From: Matthew Wilcox Subject: Re: [PATCH 1/6] lockdep: allow to disable reclaim lockup detection Message-ID: <20170206152400.GK2267@bombadil.infradead.org> References: <20170206140718.16222-1-mhocko@kernel.org> <20170206140718.16222-2-mhocko@kernel.org> <20170206142641.GG2267@bombadil.infradead.org> <20170206143449.GD10298@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170206143449.GD10298@dhcp22.suse.cz> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Michal Hocko Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , djwong@kernel.org, Theodore Ts'o , Chris Mason , David Sterba , Jan Kara , ceph-devel@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, logfs@logfs.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-f2fs-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, LKML On Mon, Feb 06, 2017 at 03:34:50PM +0100, Michal Hocko wrote: > This part is not needed for the patch, strictly speaking but I wanted to > make the code more future proof. Understood. I took an extra bit myself for marking the radix tree as being used for an IDR (so the radix tree now uses 4 bits). I see you already split out the address space GFP mask from the other flags :-) I would prefer not to do that with the radix tree, but I understand your desire for more GFP bits. I'm not entirely sure that an implicit gfpmask makes a lot of sense for the radix tree, but it'd be a big effort to change all the callers. Anyway, I'm going to update your line here for my current tree and add the build bug so we'll know if we ever hit any problems.