From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/3] xfs: restore and enhance xfs indlen test
Date: Fri, 10 Feb 2017 11:32:07 -0500 [thread overview]
Message-ID: <20170210163207.GB3155@bfoster.bfoster> (raw)
In-Reply-To: <20170210162523.GB6813@birch.djwong.org>
On Fri, Feb 10, 2017 at 08:25:23AM -0800, Darrick J. Wong wrote:
> On Fri, Feb 10, 2017 at 08:58:30AM -0500, Brian Foster wrote:
> > On Fri, Feb 10, 2017 at 03:15:19PM +0800, Eryu Guan wrote:
> > > On Thu, Feb 09, 2017 at 02:43:41PM -0500, Brian Foster wrote:
> > > > Hi all,
> > > >
> > > > This series is associated with the "buffered write and indlen fixes"
> > > > series recently posted to the XFS list. These patches move the original
> > > > test to the XFS directory as it now depends on an XFS-specific
> > > > mechanism, restore the effectiveness of the original test, and finally
> > > > enhance the test to reproduce the newly identified problems fixed by the
> > > > kernel patches. Thoughts, reviews, flames appreciated.
> > >
> > > I think it's still worth keeping the original fzero tests in generic, as
> > > a generic function/regression test, though it's not effective to
> > > reproduce the original bug. And maybe it's still working and effective
> > > on some distro kernels? How about just adding a new test for XFS?
> > >
> >
> > Sure, in that case I guess I can just copy generic/033 rather than move
> > it and then squash these down into a single patch. Any other comments on
> > the resulting test before I post an update?
>
> /me thinks the new test ought to _notrun if the fail_writes file doesn't
> show up... that said /me is sorta braindead after a lot of travel
> yesterday and could've missed it already being there. :(
>
Yep, there's a '_require_xfs_sysfs ...' in there that skips the test as
appropriate.
Brian
> --D
>
> >
> > Brian
> >
> > > Thanks,
> > > Eryu
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-02-10 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 19:43 [PATCH 0/3] xfs: restore and enhance xfs indlen test Brian Foster
2017-02-09 19:43 ` [PATCH 1/3] xfstests: move generic indlen reservation test to xfs dir Brian Foster
2017-02-09 19:43 ` [PATCH 2/3] tests/xfs: update indlen res. test to use fail writes mechanism Brian Foster
2017-02-09 19:43 ` [PATCH 3/3] tests/xfs: update indlen res. test to include larger write pattern Brian Foster
2017-02-10 7:15 ` [PATCH 0/3] xfs: restore and enhance xfs indlen test Eryu Guan
2017-02-10 13:58 ` Brian Foster
2017-02-10 16:25 ` Darrick J. Wong
2017-02-10 16:32 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210163207.GB3155@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).