From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Seth Forshee <seth.forshee@canonical.com>
Subject: Re: xfs: fix inode uid/gid initialization
Date: Mon, 13 Feb 2017 22:08:09 -0800 [thread overview]
Message-ID: <20170214060809.GA21114@infradead.org> (raw)
In-Reply-To: <20170213213416.GA15349@dastard>
On Tue, Feb 14, 2017 at 08:34:16AM +1100, Dave Chinner wrote:
> >
> > - if (pip && XFS_INHERIT_GID(pip)) {
> > - ip->i_d.di_gid = pip->i_d.di_gid;
> > - if ((VFS_I(pip)->i_mode & S_ISGID) && S_ISDIR(mode))
> > - inode->i_mode |= S_ISGID;
> > - }
> > -
>
> Doesn't this hunk break the "nogrpid" mount option?
It does.
next prev parent reply other threads:[~2017-02-14 6:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 17:46 xfs: fix inode uid/gid initialization James Bottomley
2017-02-13 19:43 ` Christoph Hellwig
2017-02-13 20:33 ` James Bottomley
2017-02-13 21:34 ` Dave Chinner
2017-02-14 6:08 ` Christoph Hellwig [this message]
2017-02-14 6:27 ` James Bottomley
2017-02-14 6:28 ` [PATCH 1/2] fs: add inode helpers for fsuid and fsgid James Bottomley
2017-02-14 7:46 ` Eric W. Biederman
2017-02-14 8:00 ` Christoph Hellwig
2017-02-14 16:09 ` James Bottomley
2017-02-15 2:29 ` Eric W. Biederman
2017-02-16 15:43 ` James Bottomley
2017-02-17 1:15 ` Eric W. Biederman
2017-02-17 17:12 ` James Bottomley
2017-02-20 4:56 ` Eric W. Biederman
2017-02-14 6:29 ` [PATCH 2/2] xfs: fix inode uid/gid initialization James Bottomley
2017-02-14 7:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214060809.GA21114@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=david@fromorbit.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).