From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>, dan.carpenter@oracle.com
Subject: Re: [PATCH] xfs: fix uninitialized variable in _reflink_convert_cow
Date: Tue, 14 Feb 2017 08:04:47 -0500 [thread overview]
Message-ID: <20170214130447.GB3223@bfoster.bfoster> (raw)
In-Reply-To: <20170214065417.GC6813@birch.djwong.org>
On Mon, Feb 13, 2017 at 10:54:17PM -0800, Darrick J. Wong wrote:
> Fix an uninitialized variable.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_reflink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
> index 2f3d2d5..da6d08f 100644
> --- a/fs/xfs/xfs_reflink.c
> +++ b/fs/xfs/xfs_reflink.c
> @@ -362,7 +362,7 @@ xfs_reflink_convert_cow(
> xfs_fileoff_t end_fsb = XFS_B_TO_FSB(mp, offset + count);
> xfs_extnum_t idx;
> bool found;
> - int error;
> + int error = 0;
>
> xfs_ilock(ip, XFS_ILOCK_EXCL);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-14 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 6:54 [PATCH] xfs: fix uninitialized variable in _reflink_convert_cow Darrick J. Wong
2017-02-14 13:04 ` Brian Foster [this message]
2017-02-16 20:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214130447.GB3223@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox