From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: transaction reservations for deleting of shared extents
Date: Mon, 20 Feb 2017 08:29:45 +0100 [thread overview]
Message-ID: <20170220072945.GA17608@lst.de> (raw)
Hi Darrick,
I got a bug report about running out of log reservations when deleting
heavily reflinked files.
We're hitting the ASSERT(tp->t_ticket->t_curr_res >= len) in
xlog_cil_insert_items and it seems we are way above the reservation.
I started auditing the issue and it seems like we don't account for
the refcountbt adjustments at all in tr_itruncate. Do you have any
back of the napking math around for what amount of log reservations
we should need for them? Otherwise I'll need to wade through the
code and recreate that math.
next reply other threads:[~2017-02-20 7:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 7:29 Christoph Hellwig [this message]
2017-02-21 1:43 ` transaction reservations for deleting of shared extents Darrick J. Wong
2017-02-21 9:07 ` Christoph Hellwig
2017-02-21 16:53 ` Darrick J. Wong
2017-04-12 13:52 ` Christoph Hellwig
2017-04-12 23:06 ` Darrick J. Wong
2017-04-13 3:52 ` Darrick J. Wong
2017-04-13 10:51 ` Christoph Hellwig
2017-04-13 12:13 ` Christoph Hellwig
2017-04-25 2:09 ` Darrick J. Wong
2017-06-03 7:13 ` Christoph Hellwig
2017-06-03 17:01 ` Darrick J. Wong
2017-04-13 10:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220072945.GA17608@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).