linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xfsdump: fix build on 32-bit platforms
@ 2017-02-17 21:02 Eric Sandeen
  2017-02-27  5:01 ` Eric Sandeen
  2017-02-27  8:45 ` Christoph Hellwig
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Sandeen @ 2017-02-17 21:02 UTC (permalink / raw)
  To: linux-xfs, Eric Biggers

Now that xfsprogs requires anyone using the headers to
properly define 64-bit file access, xfsdump has stopped
building on 32-bit platforms.

I think this is all it needs; works for me here.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

cc: Eric Biggers because he seems to enjoy this stuff :)

diff --git a/configure.ac b/configure.ac
index 7bb6f1d..8d78ed4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6,6 +6,8 @@ AC_CONFIG_SRCDIR([common/main.c])
 AC_CONFIG_HEADER(include/config.h)
 AC_PREFIX_DEFAULT(/usr)
 
+AC_SYS_LARGEFILE
+
 AC_PROG_LIBTOOL
 
 AC_ARG_ENABLE(shared,


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsdump: fix build on 32-bit platforms
  2017-02-17 21:02 [PATCH] xfsdump: fix build on 32-bit platforms Eric Sandeen
@ 2017-02-27  5:01 ` Eric Sandeen
  2017-02-27  8:45 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2017-02-27  5:01 UTC (permalink / raw)
  To: linux-xfs, Eric Biggers

On 2/17/17 3:02 PM, Eric Sandeen wrote:
> Now that xfsprogs requires anyone using the headers to
> properly define 64-bit file access, xfsdump has stopped
> building on 32-bit platforms.
> 
> I think this is all it needs; works for me here.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Ping?

(with the dearth of devel traffic for xfsdump, don't want this
to get lost...)

Thanks,
-Eric

> ---
> 
> cc: Eric Biggers because he seems to enjoy this stuff :)
> 
> diff --git a/configure.ac b/configure.ac
> index 7bb6f1d..8d78ed4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -6,6 +6,8 @@ AC_CONFIG_SRCDIR([common/main.c])
>  AC_CONFIG_HEADER(include/config.h)
>  AC_PREFIX_DEFAULT(/usr)
>  
> +AC_SYS_LARGEFILE
> +
>  AC_PROG_LIBTOOL
>  
>  AC_ARG_ENABLE(shared,
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsdump: fix build on 32-bit platforms
  2017-02-17 21:02 [PATCH] xfsdump: fix build on 32-bit platforms Eric Sandeen
  2017-02-27  5:01 ` Eric Sandeen
@ 2017-02-27  8:45 ` Christoph Hellwig
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-02-27  8:45 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-xfs, Eric Biggers

Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-27 10:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-17 21:02 [PATCH] xfsdump: fix build on 32-bit platforms Eric Sandeen
2017-02-27  5:01 ` Eric Sandeen
2017-02-27  8:45 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).