linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Marcel Partap <mpartap@gmx.net>, linux-xfs@vger.kernel.org
Subject: Re: Why does fsck.xfs not do what xfs_repair -n does?
Date: Mon, 27 Feb 2017 19:26:46 +0100	[thread overview]
Message-ID: <20170227182646.GO31264@wotan.suse.de> (raw)
In-Reply-To: <20170227081636.2evil6tpv75o5ldw@eorzea.usersys.redhat.com>

On Mon, Feb 27, 2017 at 09:16:36AM +0100, Carlos Maiolino wrote:
> On Fri, Feb 24, 2017 at 09:49:17PM +0100, Marcel Partap wrote:
> > Dear XFS dev crew,
> > > fsck.xfs(8)
> > >         fsck.xfs - do nothing, successfully
> > >         If you wish to check the consistency of an XFS filesystem, or repair a damaged or corrupt XFS filesystem, see xfs_repair(8).
> > 
> > So there's a FS check command that does not work as with all the other
> > filesystems. Instead of checking the FS, it tells you to use xfs_repair
> > both for - XFS repair.. and XFS check. Whereas in the man page of
> > > xfs_repair - repair an XFS filesystem
> > it doesn't tell you right at the top that xfs_repair can check XFS. Instead
> > > *       -n     No modify mode. Specifies that xfs_repair should […]  *scan  the  filesystem*
> 
> Xfs used to have two different tools for that. xfs_check and xfs_repair. This
> required one more tool, several more lines of code to be maintained, while
> xfs_repair does the check job with '-n' option, so, it was decided to deprecate
> xfs_check and keep efforts only in xfs_repair.

A symlink to xfs_check and a check for the alias would have sufficed to keep the
old interface while sharing code. That can be considered should folks agree this
desirable and should be a few lines of code.

  Luis

  parent reply	other threads:[~2017-02-27 19:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 20:49 Why does fsck.xfs not do what xfs_repair -n does? Marcel Partap
2017-02-27  8:16 ` Carlos Maiolino
2017-02-27 15:37   ` Eric Sandeen
2017-02-27 18:26   ` Luis R. Rodriguez [this message]
2017-02-27 20:04     ` Eric Sandeen
2017-02-27 20:27     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227182646.GO31264@wotan.suse.de \
    --to=mcgrof@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mpartap@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).