From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org, Mathias Troiden <mathias.troiden@gmail.com>
Subject: Re: [PATCH] xfs_repair: detect invalid zero-sized symlink inodes
Date: Wed, 1 Mar 2017 16:35:57 -0800 [thread overview]
Message-ID: <20170302003557.GA24593@infradead.org> (raw)
In-Reply-To: <1488380403-5826-1-git-send-email-bfoster@redhat.com>
> + if (be64_to_cpu(dino->di_size) == 0) {
You can drop the be64_to_cpu if you're only comparing with 0.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2017-03-02 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 15:00 [PATCH] xfs_repair: detect invalid zero-sized symlink inodes Brian Foster
2017-03-01 16:32 ` Darrick J. Wong
2017-03-02 0:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302003557.GA24593@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mathias.troiden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).