From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: try any AG when allocating the first btree block when reflinking
Date: Wed, 8 Mar 2017 18:18:59 +0100 [thread overview]
Message-ID: <20170308171859.GA27174@lst.de> (raw)
In-Reply-To: <20170308170701.GM5280@birch.djwong.org>
On Wed, Mar 08, 2017 at 09:07:01AM -0800, Darrick J. Wong wrote:
> > + if (WARN_ON_ONCE(args.fsbno == NULLFSBLOCK)) {
> > + xfs_iroot_realloc(ip, -1, whichfork);
> > + xfs_btree_del_cursor(cur, XFS_BTREE_ERROR);
> > + return -ENOMEM;
>
> ENOSPC?
Yeah.
> > + }
> > /*
> > * Allocation can't fail, the space was reserved.
> > */
>
> Can we get rid of the ASSERT(args.fsbno != NULLFSBLOCK); just below here
> now that we jump out above?
Sure.
>
> Conceptually I guess it's ok for now until we separate out the uses of
> *firstblock to stay ahead of locking rules vs. *firstblock to remap
> things. Hmm, I'll try to make a first stab at that today.
I've been working on that for a while - the problem is that it goes
up a few layers, including xfs_bmapi_write and the da_args structures.
Give me a little more time and I should have a series for you.
next prev parent reply other threads:[~2017-03-08 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 16:13 [PATCH] xfs: try any AG when allocating the first btree block when reflinking Christoph Hellwig
2017-03-08 17:07 ` Darrick J. Wong
2017-03-08 17:18 ` Christoph Hellwig [this message]
2017-03-08 18:19 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308171859.GA27174@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox