From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Jan Tulak <jtulak@redhat.com>
Cc: linux-xfs@vger.kernel.org,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Eric Sandeen <sandeen@sandeen.net>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 00/22] mkfs.xfs: Make stronger conflict checks
Date: Fri, 17 Mar 2017 00:38:45 +0100 [thread overview]
Message-ID: <20170316233845.GY28800@wotan.suse.de> (raw)
In-Reply-To: <20170315160017.27805-1-jtulak@redhat.com>
On Wed, Mar 15, 2017 at 04:59:55PM +0100, Jan Tulak wrote:
> This set is a follow-up of some old discussions and further attempts to untangle
> the spaghetti in options parsing. In short, this patchset allows to define
> cross-option conflicts and makes the conflicts detection more robust.
This series is pretty large. There are quite a bit of patches which just rename
something, or just shove code from one place to another. Can you group up
non-functional changes together first, and send a small series of simple stuff
with no functional changes first?
That should reduce the size of the functional patch set, and make it clearer
which patches require much careful eyeballing. It should also put out of your
queue tons of changes which are trivial and can go in rather sooner.
> Config file patches addendum:
>
> (Thread: http://www.spinics.net/lists/linux-xfs/msg04703.html)
>
> I read through the changes, but decided to don't take anything from it.
The last 2 patches of my config series are really the functional change there,
the rest is fluff to account for the insanity we have now.
> I think it is time to do something and adding further changes would just
> push it down again. Nevertheless, the other patchset contains some changes
> (like splitting the main opts loop) that I wanted to add in some later patch
> too.
OK.
> I suggest that we first merge these patches I'm sending, and once it solves
> some of the issues Luis hit too, we can look again on the config file thing
> and even if the main idea fell out of favor for some reason, there are still
> other useful changes.
Sure, I'm fine with this, do you have a git tree ? Once you rev and post new
series if you can provide a git URL that'd be great as then I can just work
off of that.
> PS: I'm traveling at Vault next week, so if you are there too, we can open it
> there.
I'm up for beers there.
Luis
next prev parent reply other threads:[~2017-03-16 23:40 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 15:59 [PATCH 00/22] mkfs.xfs: Make stronger conflict checks Jan Tulak
2017-03-15 15:59 ` [PATCH 01/22] mkfs: remove intermediate getstr followed by getnum Jan Tulak
2017-03-16 22:59 ` Eric Sandeen
2017-04-05 13:00 ` Jan Tulak
2017-04-05 14:05 ` Eric Sandeen
2017-03-15 15:59 ` [PATCH 02/22] mkfs: merge tables for opts parsing into one table Jan Tulak
2017-03-15 15:59 ` [PATCH 03/22] mkfs: extend opt_params with a value field Jan Tulak
2017-03-15 15:59 ` [PATCH 04/22] mkfs: change conflicts array into a table capable of cross-option addressing Jan Tulak
2017-03-16 17:02 ` Eric Sandeen
2017-03-16 17:21 ` Jan Tulak
2017-03-16 17:41 ` Eric Sandeen
2017-03-16 17:47 ` Jan Tulak
2017-03-15 16:00 ` [PATCH 05/22] mkfs: add a check for conflicting values Jan Tulak
2017-03-25 0:36 ` Eric Sandeen
2017-03-29 14:58 ` Jan Tulak
2017-03-15 16:00 ` [PATCH 06/22] mkfs: add cross-section conflict checks Jan Tulak
2017-03-25 0:31 ` Eric Sandeen
2017-03-29 14:57 ` Jan Tulak
2017-03-15 16:00 ` [PATCH 07/22] mkfs: Move opts related #define to one place Jan Tulak
2017-03-16 23:25 ` Luis R. Rodriguez
2017-03-17 12:11 ` Jan Tulak
2017-03-15 16:00 ` [PATCH 08/22] mkfs: move conflicts into the table Jan Tulak
2017-03-16 18:04 ` Eric Sandeen
2017-03-16 18:39 ` Eric Sandeen
2017-03-16 18:45 ` Darrick J. Wong
2017-03-24 23:53 ` Eric Sandeen
2017-03-29 14:57 ` Jan Tulak
2017-03-15 16:00 ` [PATCH 09/22] mkfs: change conflict checks to utilize the new conflict structure Jan Tulak
2017-03-15 16:00 ` [PATCH 10/22] mkfs: change when to mark an option as seen Jan Tulak
2017-03-15 16:00 ` [PATCH 11/22] mkfs: add test_default_value into conflict struct Jan Tulak
2017-03-25 0:09 ` Eric Sandeen
2017-03-29 14:57 ` Jan Tulak
2017-03-29 16:33 ` Jan Tulak
2017-03-31 1:40 ` Luis R. Rodriguez
2017-03-31 7:35 ` Jan Tulak
2017-03-15 16:00 ` [PATCH 12/22] mkfs: expand conflicts declarations to named declaration Jan Tulak
2017-03-15 16:00 ` [PATCH 13/22] mkfs: remove zeroed items from conflicts declaration Jan Tulak
2017-03-15 16:00 ` [PATCH 14/22] mkfs: rename defaultval to flagval in opts Jan Tulak
2017-03-16 23:20 ` Luis R. Rodriguez
2017-03-17 12:06 ` Jan Tulak
2017-03-15 16:00 ` [PATCH 15/22] mkfs: replace SUBOPT_NEEDS_VAL for a flag Jan Tulak
2017-03-15 16:00 ` [PATCH 16/22] mkfs: Change all value fields in opt structures into unions Jan Tulak
2017-03-15 16:00 ` [PATCH 17/22] mkfs: use old variables as pointers to the new opts struct values Jan Tulak
2017-03-17 0:48 ` Eric Sandeen
2017-03-15 16:00 ` [PATCH 18/22] mkfs: prevent sector/blocksize to be specified as a number of blocks Jan Tulak
2017-03-15 16:00 ` [PATCH 19/22] mkfs: subopt flags should be saved as bool Jan Tulak
2017-03-15 16:00 ` [PATCH 20/22] mkfs: move uuid empty string test to getstr() Jan Tulak
2017-03-15 16:00 ` [PATCH 21/22] mkfs: remove duplicit checks Jan Tulak
2017-03-15 16:00 ` [PATCH 22/22] mkfs: prevent multiple specifications of a single option Jan Tulak
2017-03-16 17:19 ` [PATCH 00/22] mkfs.xfs: Make stronger conflict checks Eric Sandeen
2017-03-16 17:23 ` Jan Tulak
2017-03-16 23:38 ` Luis R. Rodriguez [this message]
2017-03-16 23:47 ` Eric Sandeen
2017-03-17 12:57 ` Jan Tulak
2017-03-18 7:08 ` Dave Chinner
2017-03-17 12:20 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316233845.GY28800@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=david@fromorbit.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).