linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
	Brian Foster <bfoster@redhat.com>,
	xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: move the inline directory verifiers
Date: Fri, 31 Mar 2017 09:24:31 -0700	[thread overview]
Message-ID: <20170331162431.GF4864@birch.djwong.org> (raw)
In-Reply-To: <20170331160743.GB3255@infradead.org>

On Fri, Mar 31, 2017 at 09:07:43AM -0700, Christoph Hellwig wrote:
> On Thu, Mar 30, 2017 at 09:41:10AM +1100, Dave Chinner wrote:
> > > > I lost track of the fact that the first patch went into -rc and thus
> > > > confused myself over where this should apply. This applies to 4.11.0-rc4
> > > > and looks fine to me:
> > > 
> > > Does anyone have a problem if I send this to Linus for 4.11-rc5?
> > > I'd rather atone for my sins sooner than later. :)
> > 
> > There's no urgency required here - it's just a cleanup patch. The
> > code in the tree works fine, so why risk adding regressions
> > at a late stage? Just add it to the for-next queue and let it soak
> > until the merge window.
> 
> Is current Linus tree ok?  I'm pretty sure a recent Linus tree fell
> over when running the dir fuzzers for me.  Which commit would the
> latest actual fix be?

I think xfs/348 causes -rc4 to fall over if CONFIG_XFS_DEBUG=y due to
the XFS_WANT_CORRUPTED_RETURNs that shouldn't be there.

--D

> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-03-31 16:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 23:03 [PATCH v2] xfs: move the inline directory verifiers Darrick J. Wong
2017-03-28 12:51 ` Brian Foster
2017-03-28 15:00   ` Darrick J. Wong
2017-03-28 15:11     ` Brian Foster
2017-03-28 17:24       ` Brian Foster
2017-03-29 18:21         ` Darrick J. Wong
2017-03-29 18:52           ` Brian Foster
2017-03-29 22:41           ` Dave Chinner
2017-03-31 16:07             ` Christoph Hellwig
2017-03-31 16:24               ` Darrick J. Wong [this message]
2017-03-31 16:28                 ` Christoph Hellwig
2017-03-31 16:38                   ` Darrick J. Wong
2017-03-31 16:40                     ` Christoph Hellwig
2017-04-01 23:17                       ` Dave Chinner
2017-03-31 17:24 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331162431.GF4864@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).