Re: [PATCH 4/4] xfstests: Check the stx_attributes settable by chattr [ver #5]

Eryu Guan
2017-04-05T11:30:13Z

On Wed, Apr 05, 2017 at 12:11:38PM +0100, David Howells wrote:
> Eryu Guan <eguan@redhat.com> wrote:
>
> > Need a "Silence is golden" output to indicate this test expects no
> > output.
>
> But why is it needed? You have an exit code. Further, it's not in the .out
> file, so you can see just by looking at that that there's no output expected.

Yes, it's not a must-have from the test's point of view. But it's kind
of xfstests' convention. xfstests takes it as a clear indication that
this test expects no output, so anyone who's familiar with xfstests
knows the test has no output and isn't surprised. Without this message
people just get confused and wonder what's the expected result.

As Amir pointed out, not all tests with empty output print this message
(mostly some really old tests), but most of such tests do print.

>
> Actually, how do I *prevent* the output comparator from comparing? I really
> want to print out what chattr+statx tests I'm actually running (as opposed to
> the ones I'm skipping), but I can't do that because the output comparator
> would bark.

You could dump & append any debug message to $seqres.full file, it's for
debug purpose and it defaults to <xfstests>/result/generic/421.full

e.g.
echo "a=$a_supported d=$d_supported c=$c_supported i=$i_supported" >>$seqres.full

Thanks,
Eryu