From: Bill O'Donnell <billodo@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH] xfsprogs: ensure growfs rejects non-existent mount point
Date: Fri, 7 Apr 2017 12:58:09 -0500 [thread overview]
Message-ID: <20170407175809.8540-1-billodo@redhat.com> (raw)
xfs_growfs manpage clearly states that the filesystem must
be mounted to be grown. Current behavior allows xfs_growfs
to proceed if the filesystem /containing/ the path
of the desired target is mounted. This is not the specified
behavior. Instead, also check the targeted fs argument against
the entry found in the fstable lookup. Unless the targeted
fs is actually mounted, reject the command.
Signed-off-by: Bill O'Donnell <billodo@redhat.com>
---
growfs/xfs_growfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/growfs/xfs_growfs.c b/growfs/xfs_growfs.c
index a294e14..05630b8 100644
--- a/growfs/xfs_growfs.c
+++ b/growfs/xfs_growfs.c
@@ -203,7 +203,7 @@ main(int argc, char **argv)
fs_table_initialise(0, NULL, 0, NULL);
fs = fs_table_lookup(argv[optind], FS_MOUNT_POINT);
- if (!fs) {
+ if (!fs || (strcmp(argv[optind], fs->fs_dir) != 0)) {
fprintf(stderr, _("%s: %s is not a mounted XFS filesystem\n"),
progname, argv[optind]);
return 1;
--
2.9.3
next reply other threads:[~2017-04-07 17:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 17:58 Bill O'Donnell [this message]
2017-04-07 18:33 ` [PATCH] xfsprogs: ensure growfs rejects non-existent mount point Darrick J. Wong
2017-04-07 18:51 ` Eric Sandeen
2017-04-11 23:20 ` Bill O'Donnell
2017-04-11 17:22 ` [PATCH v2] " Bill O'Donnell
2017-04-19 22:05 ` Eric Sandeen
2017-04-19 22:08 ` Bill O'Donnell
2017-04-20 22:22 ` Eric Sandeen
2017-04-20 22:43 ` Eric Sandeen
2017-04-24 14:29 ` [PATCH v3] " Bill O'Donnell
2017-04-26 22:23 ` Eric Sandeen
2017-04-27 18:23 ` [PATCH v4] xfs_growfs: ensure target path is an active xfs mountpoint Bill O'Donnell
2017-04-27 19:15 ` Eric Sandeen
2017-05-03 16:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407175809.8540-1-billodo@redhat.com \
--to=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).