Re: [PATCH 4/4] xfs_db: dump metadata btrees via 'btdump'

[Dave Chinner <david@fromorbit.com>]

On Fri, Apr 07, 2017 at 08:04:07PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Introduce a new 'btdump' command that can print the contents of all
> blocks of any metadata subtree in the filesystem.  This enables
> developers and forensic analyst to view a metadata structure without
> having to navigate the btree manually.
....

Something I've noticed recently:

> --- /dev/null
> +++ b/db/btdump.h
> @@ -0,0 +1,20 @@
> +/*
> + * Copyright (C) 2017 Oracle.  All Rights Reserved.
> + *
> + * Author: Darrick J. Wong <darrick.wong@oracle.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it would be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write the Free Software Foundation,
> + * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301, USA.
> + */
> +extern void	btdump_init(void);

Adding a new header file just for an extern init function
declarationi is a pretty silly pattern. Just consolidate all the
init function declarations db/init.h, and get rid of all the
one-line headers...

We should really do the same for xfs_io, too...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com