From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/6] xfs: pass individual arguments to xfs_bmap_add_extent_hole_real
Date: Mon, 10 Apr 2017 19:42:34 +0200 [thread overview]
Message-ID: <20170410174234.GB19106@lst.de> (raw)
In-Reply-To: <20170410171316.GV4864@birch.djwong.org>
On Mon, Apr 10, 2017 at 10:13:16AM -0700, Darrick J. Wong wrote:
> > - struct xfs_bmalloca *bma,
> > - int whichfork)
> > + struct xfs_trans *tp,
> > + xfs_inode_t *ip, /* incore inode pointer */
> > + int whichfork,
> > + xfs_extnum_t *idx, /* extent number to update/insert */
> > + xfs_btree_cur_t **curp, /* if *curp is null, not a btree */
> > + xfs_bmbt_irec_t *new, /* new data to add to file extents */
>
> struct xfs_inode vs. xfs_inode_t ?
Sure, I can fix this up.
>
> I was under the impression that we don't add comments to the function
> arguments anymore, but TBH they don't bother me.
It's copy and paste from the other function in the family that
takes individual parameters. I can remove it.
next prev parent reply other threads:[~2017-04-10 17:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 12:18 split the reflink remap from the block allocation path Christoph Hellwig
2017-04-03 12:18 ` [PATCH 1/6] xfs: fix integer truncation in xfs_bmap_remap_alloc Christoph Hellwig
2017-04-10 16:48 ` Darrick J. Wong
2017-04-03 12:18 ` [PATCH 2/6] xfs: remove attr fork handling in xfs_bmap_finish_one Christoph Hellwig
2017-04-10 17:05 ` Darrick J. Wong
2017-04-10 17:41 ` Christoph Hellwig
2017-04-03 12:18 ` [PATCH 3/6] xfs: pass individual arguments to xfs_bmap_add_extent_hole_real Christoph Hellwig
2017-04-10 17:13 ` Darrick J. Wong
2017-04-10 17:42 ` Christoph Hellwig [this message]
2017-04-03 12:18 ` [PATCH 4/6] xfs: introduce xfs_bmapi_remap Christoph Hellwig
2017-04-10 19:50 ` Darrick J. Wong
2017-04-11 5:42 ` Christoph Hellwig
2017-04-03 12:18 ` [PATCH 5/6] xfs: remove xfs_bmap_remap_alloc Christoph Hellwig
2017-04-03 17:37 ` Darrick J. Wong
2017-04-03 12:18 ` [PATCH 6/6] xfs: remove bmap block allocation retries Christoph Hellwig
2017-04-10 19:57 ` Darrick J. Wong
2017-04-10 7:36 ` split the reflink remap from the block allocation path Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2017-04-11 11:10 split the reflink remap from the block allocation path V2 Christoph Hellwig
2017-04-11 11:10 ` [PATCH 3/6] xfs: pass individual arguments to xfs_bmap_add_extent_hole_real Christoph Hellwig
2017-04-11 21:48 ` Darrick J. Wong
2017-04-12 10:30 split the reflink remap from the block allocation path V3 Christoph Hellwig
2017-04-12 10:30 ` [PATCH 3/6] xfs: pass individual arguments to xfs_bmap_add_extent_hole_real Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410174234.GB19106@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).