Re: [PATCH 2/2] mdrestore: warn about corruption if log is dirty

[Dave Chinner <david@fromorbit.com>]

On Tue, Apr 11, 2017 at 04:12:37PM +0200, Jan Tulak wrote:
> A dirty log in an obfuscated dump means that a corruption can happen
> when replaying the log (which contains unobfuscated data). Warn the user
> about this possibility.
> 
> The xlog workaround is copy&paste solution from repair/phase2.c and
> other tools, because the function is not implemented in libxlog.
> 
> Signed-off-by: Jan Tulak <jtulak@redhat.com>

I think this is overkill. mdrestore is not the place
to be interpreting the state of the dumped image - it is a basic
"restore the image" program, not a "check the validity of the image"
program.

Secondly, if people are having problems with running log recovery on
a restored obfuscated image and getting corruption and not knowing
why or what to do, then that is a /documentation and training/
problem, not a code problem.

i.e. the problem is that people who aren't developers are trying to
use tools that were written for developers to do forensic analysis
of failures. Don't dumb down the tool for clueless users - point the
users at the documentation that the tool requires to use correctly...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com