From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: transaction reservations for deleting of shared extents
Date: Wed, 12 Apr 2017 15:52:31 +0200 [thread overview]
Message-ID: <20170412135231.GA3891@lst.de> (raw)
In-Reply-To: <20170221014356.GA5844@birch.djwong.org>
I think the problem is that t_log_res just contains the log reservation
when the transaction was created. But each item processed by
xfs_defer_finish uses up some of it, but in some cases these might
be different operations and not just more refcount updates, e.g. for
xfs_itruncate_extents which I see the issues with we mix EFI/EFD
items with refcount updates.
I still don't have a good idea how to fix this, though. One idea
would be to prevent mixing different items, but I think being able
to mix them was one of your goals with the defer infrastructure rewrite.
next prev parent reply other threads:[~2017-04-12 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 7:29 transaction reservations for deleting of shared extents Christoph Hellwig
2017-02-21 1:43 ` Darrick J. Wong
2017-02-21 9:07 ` Christoph Hellwig
2017-02-21 16:53 ` Darrick J. Wong
2017-04-12 13:52 ` Christoph Hellwig [this message]
2017-04-12 23:06 ` Darrick J. Wong
2017-04-13 3:52 ` Darrick J. Wong
2017-04-13 10:51 ` Christoph Hellwig
2017-04-13 12:13 ` Christoph Hellwig
2017-04-25 2:09 ` Darrick J. Wong
2017-06-03 7:13 ` Christoph Hellwig
2017-06-03 17:01 ` Darrick J. Wong
2017-04-13 10:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412135231.GA3891@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).