* [PATCH v2] xfs: actually report xattr extents via iomap
@ 2017-04-07 17:25 Darrick J. Wong
2017-04-07 17:29 ` Brian Foster
2017-04-12 15:17 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2017-04-07 17:25 UTC (permalink / raw)
To: xfs; +Cc: Eryu Guan, Christoph Hellwig, Eric Sandeen, Brian Foster
Apparently FIEMAP for xattrs has been broken since we switched to
the iomap backend because of an incorrect check for xattr presence.
Also fix the broken locking.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_iomap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 009f824..b2f0901 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -1170,10 +1170,10 @@ xfs_xattr_iomap_begin(
if (XFS_FORCED_SHUTDOWN(mp))
return -EIO;
- lockmode = xfs_ilock_data_map_shared(ip);
+ lockmode = xfs_ilock_attr_map_shared(ip);
/* if there are no attribute fork or extents, return ENOENT */
- if (XFS_IFORK_Q(ip) || !ip->i_d.di_anextents) {
+ if (!XFS_IFORK_Q(ip) || !ip->i_d.di_anextents) {
error = -ENOENT;
goto out_unlock;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] xfs: actually report xattr extents via iomap
2017-04-07 17:25 [PATCH v2] xfs: actually report xattr extents via iomap Darrick J. Wong
@ 2017-04-07 17:29 ` Brian Foster
2017-04-12 15:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Brian Foster @ 2017-04-07 17:29 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs, Eryu Guan, Christoph Hellwig, Eric Sandeen
On Fri, Apr 07, 2017 at 10:25:41AM -0700, Darrick J. Wong wrote:
> Apparently FIEMAP for xattrs has been broken since we switched to
> the iomap backend because of an incorrect check for xattr presence.
> Also fix the broken locking.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_iomap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 009f824..b2f0901 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -1170,10 +1170,10 @@ xfs_xattr_iomap_begin(
> if (XFS_FORCED_SHUTDOWN(mp))
> return -EIO;
>
> - lockmode = xfs_ilock_data_map_shared(ip);
> + lockmode = xfs_ilock_attr_map_shared(ip);
>
> /* if there are no attribute fork or extents, return ENOENT */
> - if (XFS_IFORK_Q(ip) || !ip->i_d.di_anextents) {
> + if (!XFS_IFORK_Q(ip) || !ip->i_d.di_anextents) {
> error = -ENOENT;
> goto out_unlock;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] xfs: actually report xattr extents via iomap
2017-04-07 17:25 [PATCH v2] xfs: actually report xattr extents via iomap Darrick J. Wong
2017-04-07 17:29 ` Brian Foster
@ 2017-04-12 15:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-04-12 15:17 UTC (permalink / raw)
To: Darrick J. Wong
Cc: xfs, Eryu Guan, Christoph Hellwig, Eric Sandeen, Brian Foster
I still think this isn't a feature we should support. For debug
we already have our xfs ioctl..
But if you want to keep it around:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-12 15:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-07 17:25 [PATCH v2] xfs: actually report xattr extents via iomap Darrick J. Wong
2017-04-07 17:29 ` Brian Foster
2017-04-12 15:17 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox