From: Jan Tulak <jtulak@redhat.com>
To: linux-xfs@vger.kernel.org
Cc: Jan Tulak <jtulak@redhat.com>
Subject: [PATCH 1/2] metadump: warn about corruption if log is dirty
Date: Thu, 13 Apr 2017 10:13:53 +0200 [thread overview]
Message-ID: <20170413081354.22170-2-jtulak@redhat.com> (raw)
In-Reply-To: <20170413081354.22170-1-jtulak@redhat.com>
Add a warning about possible corruption when exporting a dirty log, as
the log content does not agree with obfuscated metadata.
Signed-off-by: Jan Tulak <jtulak@redhat.com>
---
Change: More elaborate warning message.
---
db/metadump.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/db/metadump.c b/db/metadump.c
index 66952f6..2dd8593 100644
--- a/db/metadump.c
+++ b/db/metadump.c
@@ -2726,7 +2726,9 @@ copy_log(void)
/* keep the dirty log */
if (obfuscate)
print_warning(
-_("Filesystem log is dirty; image will contain unobfuscated metadata in log."));
+_("Warning: log recovery of an obfuscated metadata image can leak "
+"unobfuscated metadata and/or cause image corruption. Please mount "
+"the source filesystem to clean the log or disable obfuscation, if possible."));
break;
case -1:
/* log detection error */
--
2.1.4
next prev parent reply other threads:[~2017-04-13 8:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 8:13 [PATCH 0/2 v2] xfsprogs: metadump warns about dirty journal Jan Tulak
2017-04-13 8:13 ` Jan Tulak [this message]
2017-04-13 11:54 ` [PATCH 1/2] metadump: warn about corruption if log is dirty Brian Foster
2017-06-15 0:06 ` Eric Sandeen
2017-06-15 11:23 ` Brian Foster
2017-04-13 8:13 ` [PATCH 2/2] xfsprogs: update man for metadump about dirty log/obfuscation issue Jan Tulak
2017-04-13 12:01 ` Brian Foster
2017-04-13 12:29 ` Jan Tulak
2017-04-13 13:04 ` Brian Foster
2017-04-13 13:49 ` Eric Sandeen
2017-04-13 15:50 ` Darrick J. Wong
2017-04-13 17:01 ` Eric Sandeen
2017-04-13 17:06 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2017-04-11 14:12 [PATCH 0/2] xfsprogs: metadump/mdrestore warns about dirty journal Jan Tulak
2017-04-11 14:12 ` [PATCH 1/2] metadump: warn about corruption if log is dirty Jan Tulak
2017-04-11 18:30 ` Brian Foster
2017-04-11 18:34 ` Eric Sandeen
2017-04-11 18:43 ` Brian Foster
2017-04-11 19:01 ` Eric Sandeen
2017-04-11 23:44 ` Darrick J. Wong
2017-04-12 11:03 ` Brian Foster
2017-04-12 11:24 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413081354.22170-2-jtulak@redhat.com \
--to=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).