linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: transaction reservations for deleting of shared extents
Date: Thu, 13 Apr 2017 12:33:22 +0200	[thread overview]
Message-ID: <20170413103322.GA29553@lst.de> (raw)
In-Reply-To: <20170412230612.GS8502@birch.djwong.org>

On Wed, Apr 12, 2017 at 04:06:12PM -0700, Darrick J. Wong wrote:
> So I think the problem you're seeing here is that just prior to (3g) we
> have the most deferred items (EFIs, specifically) attached to this
> transaction at any point in the whole operation.  There can be so many
> EFIs that we use up the log reservation and blow the ASSERT.

Yes.  I think that's exactly what I'm seing, except that rmap isn't
part of the game.

> > I still don't have a good idea how to fix this, though.  One idea
> > would be to prevent mixing different items, but I think being able
> > to mix them was one of your goals with the defer infrastructure rewrite.
> 
> Yes, we have to be able to perform several different types of updates
> in one defer_ops so that we can execute CoW remappings atomically.

In one defer_ops, but I don't see anything preventing us from starting
a new chained transaction everytime we move from one type to another.

      parent reply	other threads:[~2017-04-13 10:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20  7:29 transaction reservations for deleting of shared extents Christoph Hellwig
2017-02-21  1:43 ` Darrick J. Wong
2017-02-21  9:07   ` Christoph Hellwig
2017-02-21 16:53     ` Darrick J. Wong
2017-04-12 13:52   ` Christoph Hellwig
2017-04-12 23:06     ` Darrick J. Wong
2017-04-13  3:52       ` Darrick J. Wong
2017-04-13 10:51         ` Christoph Hellwig
2017-04-13 12:13         ` Christoph Hellwig
2017-04-25  2:09           ` Darrick J. Wong
2017-06-03  7:13             ` Christoph Hellwig
2017-06-03 17:01               ` Darrick J. Wong
2017-04-13 10:33       ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170413103322.GA29553@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).