From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Jan Tulak <jtulak@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] mkfs: unify numeric types of main variables in main()
Date: Thu, 20 Apr 2017 15:28:59 +0200 [thread overview]
Message-ID: <20170420132859.GU28800@wotan.suse.de> (raw)
In-Reply-To: <20170420083323.12524-1-jtulak@redhat.com>
On Thu, Apr 20, 2017 at 10:33:23AM +0200, Jan Tulak wrote:
> Thus, uint64_t is the best candidate as the target
> type for numeric values. The existing uses of __uint64_t in mkfs change to the
> standard uint64_t type.
<-- snip -->
> CHANGES:
> * __uint64_t -> uint64_t
<-- snip -->
> diff --git a/include/xfs_multidisk.h b/include/xfs_multidisk.h
> index ce9bbce..ab74536 100644
> --- a/include/xfs_multidisk.h
> +++ b/include/xfs_multidisk.h
> @@ -57,7 +57,7 @@
> #define XFS_NOMULTIDISK_AGLOG 2 /* 4 AGs */
> #define XFS_MULTIDISK_AGCOUNT (1 << XFS_MULTIDISK_AGLOG)
>
> -extern long long cvtnum(unsigned int blksize, unsigned int sectsize,
> +extern __uint64_t cvtnum(unsigned int blksize, unsigned int sectsize,
I thought uint64_t was desired ?
> -long long
> +uint64_t
> cvtnum(
> unsigned int blksize,
> unsigned int sectsize,
> const char *s)
> {
Indeed. Probably just a missed case?
Luis
next prev parent reply other threads:[~2017-04-20 13:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 15:30 [PATCH 1/2] mkfs: unify numeric types of main variables in main() Jan Tulak
2017-04-19 15:30 ` [PATCH 2/2] mkfs: remove long long type casts Jan Tulak
2017-04-20 8:33 ` [PATCH 2/2 v2] " Jan Tulak
2017-04-25 1:40 ` [PATCH 2/2] " Luis R. Rodriguez
2017-04-20 0:09 ` [PATCH 1/2] mkfs: unify numeric types of main variables in main() Dave Chinner
2017-04-20 8:06 ` Jan Tulak
2017-04-20 8:33 ` [PATCH 1/2 v2] " Jan Tulak
2017-04-20 13:28 ` Luis R. Rodriguez [this message]
2017-04-20 13:57 ` Jan Tulak
2017-04-26 3:58 ` Eric Sandeen
2017-04-26 7:58 ` Jan Tulak
2017-05-09 15:49 ` Eric Sandeen
2017-04-20 13:58 ` [PATCH 1/2 v3] " Jan Tulak
2017-04-25 1:37 ` Luis R. Rodriguez
2017-04-25 12:07 ` Jan Tulak
2017-04-26 1:57 ` Luis R. Rodriguez
2017-04-26 8:03 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420132859.GU28800@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).