From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs: don't use bool values in trace buffers
Date: Sun, 23 Apr 2017 09:38:17 +0200 [thread overview]
Message-ID: <20170423073817.GA20524@lst.de> (raw)
In-Reply-To: <20170421193321.GJ23371@birch.djwong.org>
On Fri, Apr 21, 2017 at 12:33:21PM -0700, Darrick J. Wong wrote:
> On Fri, Apr 21, 2017 at 05:21:22PM +0200, Christoph Hellwig wrote:
> > Using bool values produces sparse warnings of this form:
> >
> > fs/xfs/./xfs_trace.h:2252:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
> > fs/xfs/./xfs_trace.h:2252:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
> > fs/xfs/./xfs_trace.h:2278:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
> > fs/xfs/./xfs_trace.h:2278:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
> > fs/xfs/./xfs_trace.h:2307:1: warning: odd constant _Bool cast (ffffffffffffffff becomes 1)
> >
> > Just use a char instead to fix those up.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> /me wonders what version of sparse produces this?
Latest git master HEAD:
commit ce18a906b82d0341cb33a71f7b1d8b98d11b345d
Author: Lance Richardson <lrichard@redhat.com>
Date: Wed Sep 21 10:13:58 2016 -0400
sparse: update __builtin_object_size() prototype
next prev parent reply other threads:[~2017-04-23 7:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 15:21 a few sparse inspired cleanups / fixes Christoph Hellwig
2017-04-21 15:21 ` [PATCH 1/6] xfs: use NULL instead of 0 to initialize a pointer in xfs_getfsmap Christoph Hellwig
2017-04-21 19:04 ` Darrick J. Wong
2017-04-21 15:21 ` [PATCH 2/6] xfs: use NULL instead of 0 to initialize a pointer in xfs_ioc_getfsmap Christoph Hellwig
2017-04-21 19:04 ` Darrick J. Wong
2017-04-21 15:21 ` [PATCH 3/6] xfs: corruption needs to respect endianess too! Christoph Hellwig
2017-04-21 19:05 ` Darrick J. Wong
2017-04-21 15:21 ` [PATCH 4/6] xfs: fix __user annotations for xfs_ioc_getfsmap Christoph Hellwig
2017-04-21 19:08 ` Darrick J. Wong
2017-04-21 15:21 ` [PATCH 5/6] xfs: don't use bool values in trace buffers Christoph Hellwig
2017-04-21 19:33 ` Darrick J. Wong
2017-04-23 7:38 ` Christoph Hellwig [this message]
2017-04-21 15:21 ` [PATCH 6/6] xfs: remove xfs_trans_ail_delete_bulk Christoph Hellwig
2017-04-21 19:35 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170423073817.GA20524@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox