public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs_io: fix statx definition for non-x86 architecture
@ 2017-04-24 20:29 Eric Sandeen
  2017-04-25  6:55 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2017-04-24 20:29 UTC (permalink / raw)
  To: linux-xfs; +Cc: Gwendal Grignou

Apply the same fix to xfs_io as Gwendal did for fstests:

Fix a compilation error for ARM:
__ILP32__ is defined but not __X32_SYSCALL_BIT.

The check should only apply for x86_64 architecture, statx for other
architectures is not implemented yet - see commit 7acc839c9e57
"statx: Add a system call to make enhanced file info available".

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/io/statx.h b/io/statx.h
index ff08e27..eea7944 100644
--- a/io/statx.h
+++ b/io/statx.h
@@ -18,10 +18,12 @@
 #ifndef __NR_statx
 # ifdef __i386__
 #  define __NR_statx 383
-# elif defined (__ILP32__)
-#  define __NR_statx (__X32_SYSCALL_BIT + 332)
 # elif defined (__x86_64__)
-#  define __NR_statx 332
+#  if defined (__ILP32__)
+#   define __NR_statx (__X32_SYSCALL_BIT + 332)
+#  else
+#   define __NR_statx 332
+#  endif
 # endif
 #endif
 


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs_io: fix statx definition for non-x86 architecture
  2017-04-24 20:29 [PATCH] xfs_io: fix statx definition for non-x86 architecture Eric Sandeen
@ 2017-04-25  6:55 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2017-04-25  6:55 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-xfs, Gwendal Grignou

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-25  6:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-24 20:29 [PATCH] xfs_io: fix statx definition for non-x86 architecture Eric Sandeen
2017-04-25  6:55 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox