Re: [PATCH 05/12] mkfs: extend opt_params with a value field

Jan Tulak
2017-04-26T08:51:25Z

On Wed, Apr 26, 2017 at 3:04 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> On Tue, Apr 25, 2017 at 11:39:00AM +0200, Jan Tulak wrote:
> Hm, how about:
>
> The actual value used in computations for creating the filesystem.
> This is initialized with sensible default values, if initialized to 0
> the value is considered disabled. User input can optionally override
> default values. If the field is a string and not a number, the value
> is set to a positive non-zero number when user input has been supplied.
>
>> * (If the field is a string and not a number, this value is set to
>> * a positive non-zero number on an user input.)
>>
>> And for the commit message, a bit shortened version:
>>
>> Add a new field int opt_params - value - which is the actual value
>> used in computations and for creating the filesystem. It is filled
>> with user input if the user specifies the subopt. But he does not,
>> then whatever you put there is used as the default.
>
> Modulo "But he does not"/ "but if no user input is not passed then
> the originally set defaults will be used"
>
> Luis

Sounds good. I will use your version.

Thanks,
Jan

--
Jan Tulak
jtulak@redhat.com / jan@tulak.me