From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [RFC PATCH] xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent
Date: Thu, 4 May 2017 04:59:43 -0700 [thread overview]
Message-ID: <20170504115943.GC22052@infradead.org> (raw)
In-Reply-To: <20170502120523.GA6975@bfoster.bfoster>
On Tue, May 02, 2017 at 08:05:25AM -0400, Brian Foster wrote:
> But doesn't that mean this wouldn't be a new problem introduced by such
> a change?
It would make the existing problem at lot easier to hit I think.
> transaction. That being said, I'm not following your thought wrt to this
> particular situation. Are you suggesting that we not defer the reflink
> adjustment in particular unmap cases, or that we just limit the number
> of extent unmaps per-tp based on crossing an AG boundary, or something
> else entirely?
To me it seems like we should try to do the extent count adjustments
in the current transaction for a given extent if we can, but give me
a little more time to think how to best do that. I'm travelling at the
moment and don't have much quiet time to actually engage my brain.
next prev parent reply other threads:[~2017-05-04 11:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 2:09 [RFC PATCH] xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent Darrick J. Wong
2017-04-26 13:59 ` Brian Foster
2017-04-26 21:37 ` Darrick J. Wong
2017-04-27 7:35 ` Christoph Hellwig
2017-04-28 19:40 ` Darrick J. Wong
2017-05-01 14:58 ` Brian Foster
2017-05-02 8:00 ` Christoph Hellwig
2017-05-02 12:05 ` Brian Foster
2017-05-04 11:59 ` Christoph Hellwig [this message]
2017-05-04 13:40 ` Brian Foster
2017-04-27 7:40 ` Christoph Hellwig
2017-04-27 15:58 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504115943.GC22052@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox