From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Cc: amir73il@gmail.com
Subject: [PATCH 1/3] xfs: use uuid_copy() helper to abstract uuid_t
Date: Fri, 5 May 2017 09:57:23 +0200 [thread overview]
Message-ID: <20170505075725.19597-2-hch@lst.de> (raw)
In-Reply-To: <20170505075725.19597-1-hch@lst.de>
From: Amir Goldstein <amir73il@gmail.com>
uuid_t definition is about to change.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_inode_item.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c
index 08cb7d1a4a3a..013cc78d7daf 100644
--- a/fs/xfs/xfs_inode_item.c
+++ b/fs/xfs/xfs_inode_item.c
@@ -834,9 +834,7 @@ xfs_inode_item_format_convert(
in_f->ilf_dsize = in_f32->ilf_dsize;
in_f->ilf_ino = in_f32->ilf_ino;
/* copy biggest field of ilf_u */
- memcpy(in_f->ilf_u.ilfu_uuid.__u_bits,
- in_f32->ilf_u.ilfu_uuid.__u_bits,
- sizeof(uuid_t));
+ uuid_copy(&in_f->ilf_u.ilfu_uuid, &in_f32->ilf_u.ilfu_uuid);
in_f->ilf_blkno = in_f32->ilf_blkno;
in_f->ilf_len = in_f32->ilf_len;
in_f->ilf_boffset = in_f32->ilf_boffset;
@@ -851,9 +849,7 @@ xfs_inode_item_format_convert(
in_f->ilf_dsize = in_f64->ilf_dsize;
in_f->ilf_ino = in_f64->ilf_ino;
/* copy biggest field of ilf_u */
- memcpy(in_f->ilf_u.ilfu_uuid.__u_bits,
- in_f64->ilf_u.ilfu_uuid.__u_bits,
- sizeof(uuid_t));
+ uuid_copy(&in_f->ilf_u.ilfu_uuid, &in_f64->ilf_u.ilfu_uuid);
in_f->ilf_blkno = in_f64->ilf_blkno;
in_f->ilf_len = in_f64->ilf_len;
in_f->ilf_boffset = in_f64->ilf_boffset;
--
2.11.0
next prev parent reply other threads:[~2017-05-05 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 7:57 XFS UUID cleanups Christoph Hellwig
2017-05-05 7:57 ` Christoph Hellwig [this message]
2017-05-05 7:57 ` [PATCH 2/3] xfs: use uuid_be to implement the uuid_t type Christoph Hellwig
2017-05-05 8:44 ` Amir Goldstein
2017-05-05 8:48 ` Christoph Hellwig
2017-05-05 9:42 ` Andy Shevchenko
2017-05-05 9:56 ` Christoph Hellwig
2017-05-05 10:06 ` Andy Shevchenko
2017-05-05 10:10 ` Christoph Hellwig
2017-05-10 8:39 ` Amir Goldstein
2017-05-10 12:01 ` Christoph Hellwig
2017-05-10 12:54 ` Andy Shevchenko
2017-05-10 14:15 ` Christoph Hellwig
2017-05-05 7:57 ` [PATCH 3/3] xfs: remove uuid_getnodeuniq and xfs_uu_t Christoph Hellwig
2017-05-05 8:27 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505075725.19597-2-hch@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).