From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:42256 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbdEHSlS (ORCPT ); Mon, 8 May 2017 14:41:18 -0400 Date: Mon, 8 May 2017 11:41:12 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH] ioctl_getfsmap.2: document the GETFSMAP ioctl Message-ID: <20170508184112.GJ5973@birch.djwong.org> References: <20170507155855.GD5970@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Jann Horn Cc: Michael Kerrisk-manpages , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Linux API , linux-man@vger.kernel.org On Mon, May 08, 2017 at 12:17:53AM +0200, Jann Horn wrote: > On Sun, May 7, 2017 at 5:58 PM, Darrick J. Wong wrote: > > Document the new GETFSMAP ioctl that returns the physical layout of a > > (disk-based) filesystem. > [...] > > +.B EPERM > > +This query is not allowed. > > Please document the circumstances under which a query is allowed. For the two current implementations, queries are always allowed. (The doc could be more explicit about this decision being left to the implementation.) > Also: From a quick glance at the XFS implementation, I don't see any > privilege checks. Am I missing something, or does this API permit an > unprivileged user to determine the number of physical blocks allocated > for any inode, even for inodes the user can't ordinarily see in any > way? Correct. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html