From: Christoph Hellwig <hch@lst.de>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove XFS_HSIZE
Date: Tue, 9 May 2017 23:18:57 +0200 [thread overview]
Message-ID: <20170509211857.GA2295@lst.de> (raw)
In-Reply-To: <ba048d82-a8b9-863f-121e-a1319fdef0f3@sandeen.net>
On Tue, May 09, 2017 at 10:40:31AM -0500, Eric Sandeen wrote:
> > -
> > - hsize = XFS_HSIZE(handle);
> > + hsize = sizeof(xfs_handle_t);
>
> at this point, no need to have the hsize assignment in if { } as well as else { }, right?
>
In the other branch hsize is smaller, it only covers the fsid.
next prev parent reply other threads:[~2017-05-09 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 9:00 [PATCH] xfs: remove XFS_HSIZE Christoph Hellwig
2017-05-09 15:40 ` Darrick J. Wong
2017-05-11 15:43 ` Darrick J. Wong
2017-05-11 16:54 ` Christoph Hellwig
2017-05-09 15:40 ` Eric Sandeen
2017-05-09 21:18 ` Christoph Hellwig [this message]
2017-05-09 21:26 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509211857.GA2295@lst.de \
--to=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).