From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>,
Amir Goldstein <amir73il@gmail.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 2/3] (to be folded into): uuid: hoist uuid_is_null() helper from libnvdimm
Date: Wed, 10 May 2017 18:56:11 +0300 [thread overview]
Message-ID: <20170510155612.55870-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170510155612.55870-1-andriy.shevchenko@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/uuid.h | 7 ++-----
lib/uuid.c | 5 -----
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/include/linux/uuid.h b/include/linux/uuid.h
index 2f9bdc88079e..5dcaabc1e28b 100644
--- a/include/linux/uuid.h
+++ b/include/linux/uuid.h
@@ -24,9 +24,6 @@
*/
#define UUID_STRING_LEN 36
-extern const guid_t guid_null;
-extern const uuid_t uuid_null;
-
static inline int guid_cmp(const guid_t u1, const guid_t u2)
{
return memcmp(&u1, &u2, sizeof(guid_t));
@@ -44,7 +41,7 @@ static inline void guid_copy(guid_t *dst, const guid_t *src)
static inline bool guid_is_null(guid_t *guid)
{
- return guid_equal(guid, &guid_null);
+ return guid_equal(guid, &NULL_GUID);
}
static inline int uuid_cmp(const uuid_t u1, const uuid_t u2)
@@ -64,7 +61,7 @@ static inline void uuid_copy(uuid_t *dst, const uuid_t *src)
static inline bool uuid_is_null(uuid_t *uuid)
{
- return uuid_equal(uuid, &uuid_null);
+ return uuid_equal(uuid, &NULL_UUID);
}
void generate_random_uuid(unsigned char uuid[16]);
diff --git a/lib/uuid.c b/lib/uuid.c
index 25145bfb0eaa..003bf6823003 100644
--- a/lib/uuid.c
+++ b/lib/uuid.c
@@ -21,11 +21,6 @@
#include <linux/uuid.h>
#include <linux/random.h>
-const guid_t guid_null;
-EXPORT_SYMBOL(guid_null);
-const uuid_t uuid_null;
-EXPORT_SYMBOL(uuid_null);
-
const u8 guid_index[16] = {3,2,1,0,5,4,7,6,8,9,10,11,12,13,14,15};
const u8 uuid_index[16] = {0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15};
--
2.11.0
next prev parent reply other threads:[~2017-05-10 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 15:56 [PATCH v1 1/3] (to be split and folded into): uuid: rename uuid types Andy Shevchenko
2017-05-10 15:56 ` Andy Shevchenko [this message]
2017-05-10 17:29 ` [PATCH v1 2/3] (to be folded into): uuid: hoist uuid_is_null() helper from libnvdimm Christoph Hellwig
2017-05-10 15:56 ` [PATCH v1 3/3] (to be folded into): block: remove blk_part_pack_uuid Andy Shevchenko
2017-05-10 17:31 ` Christoph Hellwig
2017-05-10 17:34 ` [PATCH v1 1/3] (to be split and folded into): uuid: rename uuid types Christoph Hellwig
2017-05-11 7:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510155612.55870-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amir73il@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).