From: Brian Foster <bfoster@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: bad assertion for delalloc an extent that start at i_size
Date: Mon, 15 May 2017 09:35:50 -0400 [thread overview]
Message-ID: <20170515133550.GC27809@bfoster.bfoster> (raw)
In-Reply-To: <1494843710-15350-1-git-send-email-zlang@redhat.com>
On Mon, May 15, 2017 at 06:21:50PM +0800, Zorro Lang wrote:
> By run fsstress long enough time enough in RHEL-7, I find an
> assertion failure (harder to reproduce on linux-4.11, but problem
> is still there):
>
> XFS: Assertion failed: (iflags & BMV_IF_DELALLOC) != 0, file: fs/xfs/xfs_bmap_util.c
>
> The assertion is in xfs_getbmap() funciton:
>
> if (map[i].br_startblock == DELAYSTARTBLOCK &&
> --> map[i].br_startoff <= XFS_B_TO_FSB(mp, XFS_ISIZE(ip)))
> ASSERT((iflags & BMV_IF_DELALLOC) != 0);
>
> When map[i].br_startoff == XFS_B_TO_FSB(mp, XFS_ISIZE(ip)), the
> startoff is just at EOF. But we only need to make sure delalloc
> extents that are within EOF, not include EOF.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_bmap_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> index 8795e9c..a6d83ea 100644
> --- a/fs/xfs/xfs_bmap_util.c
> +++ b/fs/xfs/xfs_bmap_util.c
> @@ -713,7 +713,7 @@ xfs_getbmap(
> * extents.
> */
> if (map[i].br_startblock == DELAYSTARTBLOCK &&
> - map[i].br_startoff <= XFS_B_TO_FSB(mp, XFS_ISIZE(ip)))
> + map[i].br_startoff < XFS_B_TO_FSB(mp, XFS_ISIZE(ip)))
> ASSERT((iflags & BMV_IF_DELALLOC) != 0);
>
> if (map[i].br_startblock == HOLESTARTBLOCK &&
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-05-15 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 10:21 [PATCH] xfs: bad assertion for delalloc an extent that start at i_size Zorro Lang
2017-05-15 13:35 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515133550.GC27809@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).