From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:48861 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbdEPPxJ (ORCPT ); Tue, 16 May 2017 11:53:09 -0400 Date: Tue, 16 May 2017 17:53:07 +0200 From: Christoph Hellwig Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t Message-ID: <20170516155307.GA2086@lst.de> References: <20170515154308.26739-1-hch@lst.de> <20170515154308.26739-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Amir Goldstein Cc: Christoph Hellwig , Andy Shevchenko , linux-fsdevel , Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel On Mon, May 15, 2017 at 10:38:18PM +0300, Amir Goldstein wrote: > On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig wrote: > > For some file systems we still memcpy into it, but in various places this > > already allows us to use the proper uuid helpers. More to come.. > > > > Signed-off-by: Christoph Hellwig > > --- > > > --- a/fs/xfs/xfs_mount.c > > +++ b/fs/xfs/xfs_mount.c > > @@ -75,7 +75,7 @@ xfs_uuid_mount( > > > > /* Publish UUID in struct super_block */ > > BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t)); > > BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t Yeah, you mentioned that last time and I forgot about it. Fixed up in the git tree and for the next repost.