Re: [PATCH 1/3] xfs: remove double-underscore integer types

[Dave Chinner <david@fromorbit.com>]

On Wed, May 17, 2017 at 06:30:43PM -0700, Darrick J. Wong wrote:
> This is a purely mechanical patch that removes the private
> __{u,}int{8,16,32,64}_t typedefs in favor of using the system
> {u,}int{8,16,32,64}_t typedefs.  This is the sed script used to perform
> the transformation and fix the resulting whitespace and indentation
> errors:
> 
> s/typedef\t__uint8_t/typedef __uint8_t\t/g
> s/typedef\t__uint/typedef __uint/g
> s/typedef\t__int\([0-9]*\)_t/typedef int\1_t\t/g
> s/__uint8_t\t/__uint8_t\t\t/g
> s/__uint/uint/g
> s/__int\([0-9]*\)_t\t/__int\1_t\t\t/g
> s/__int/int/g
> /^typedef.*int[0-9]*_t;$/d

I'm not sure that this is entirely correct when it comes to sparse
endian notations or the way the __ types were intended to be used.
ISTR we used the __ types were originally for the in-memory endian
converted variable definitions that shadowed the on-disk structures.
The cleanup plan I was planning to do was to convert these all to
the linux kernel definitions of __[s,u][8,16,32,64] so it was clear
they shadow on disk structures of specific sizes.

Once that was done, everything else could be converted to c99 types
(like you've done above) and then we'd be free of all the old
__[u]int*_t types....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com