linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
	Eryu Guan <eguan@redhat.com>
Subject: Re: [PATCH 0/3 v3] xfs: Fix SEEK_HOLE implementation
Date: Thu, 18 May 2017 17:06:17 -0700	[thread overview]
Message-ID: <20170519000617.GH4519@birch.djwong.org> (raw)
In-Reply-To: <20170518104850.14508-1-jack@suse.cz>

On Thu, May 18, 2017 at 12:48:47PM +0200, Jan Kara wrote:
> Hello,
> 
> this is the second revision of the patches to fix bugs in XFS's SEEK_HOLE
> implementation and cleanup the code a bit.

Looks ok, will give it a test; for now,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> 
> Changes since v2:
> * Fixed rounding error in patch 2 spotted by Eryu
> 
> Changes since v1:
> * Fixed some more buggy cases
> * Simplified code a bit as suggested by Darrick
> * Fixed range check as spotted by Brian
> 
> 								Honza
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-05-19  0:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 10:48 [PATCH 0/3 v3] xfs: Fix SEEK_HOLE implementation Jan Kara
2017-05-18 10:48 ` [PATCH 1/3] xfs: Fix missed holes in " Jan Kara
2017-05-22 17:50   ` Brian Foster
2017-05-18 10:48 ` [PATCH 2/3] xfs: Fix off-by-in in loop termination in xfs_find_get_desired_pgoff() Jan Kara
2017-05-22 17:50   ` Brian Foster
2017-05-23  3:21     ` Eryu Guan
2017-05-23  8:50       ` Jan Kara
2017-05-23 11:08         ` Eryu Guan
2017-05-23 12:17           ` Brian Foster
2017-05-23 13:05             ` Eryu Guan
2017-05-23 17:37               ` Darrick J. Wong
2017-05-23 15:30         ` Darrick J. Wong
2017-05-23 16:00           ` Brian Foster
2017-05-18 10:48 ` [PATCH 3/3] xfs: Move handling of missing page into one place " Jan Kara
2017-05-22 17:50   ` Brian Foster
2017-05-19  0:06 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519000617.GH4519@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=bfoster@redhat.com \
    --cc=eguan@redhat.com \
    --cc=jack@suse.cz \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).