From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix unaligned access in xfs_btree_visit_blocks
Date: Mon, 22 May 2017 12:07:10 -0700 [thread overview]
Message-ID: <20170522190710.GB17100@infradead.org> (raw)
In-Reply-To: <105ed603-971a-e7db-6040-b85e5eecd928@redhat.com>
On Mon, May 22, 2017 at 10:48:14AM -0500, Eric Sandeen wrote:
> This was throwing unaligned access warnings on sparc64:
>
> Kernel unaligned access at TPC[1043c088] xfs_btree_visit_blocks+0x88/0xe0 [xfs]
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 5392674..84089f8 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4395,7 +4395,7 @@ struct xfs_btree_split_args {
> xfs_btree_readahead_ptr(cur, ptr, 1);
>
> /* save for the next iteration of the loop */
> - lptr = *ptr;
> + lptr = get_unaligned(ptr);
Hm.. We don't really do this for the return value of of xfs_btree_ptr_addr
anywhere else. So if it really returns something not suitably enough
aligned we're in much deeper trouble.
next prev parent reply other threads:[~2017-05-22 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 15:48 [PATCH] xfs: fix unaligned access in xfs_btree_visit_blocks Eric Sandeen
2017-05-22 16:02 ` Eric Sandeen
2017-05-22 19:07 ` Christoph Hellwig [this message]
2017-05-22 19:40 ` Eric Sandeen
2017-05-22 20:06 ` [PATCH V2] " Eric Sandeen
2017-05-22 20:43 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522190710.GB17100@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).