From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V2] xfs: fix unaligned access in xfs_btree_visit_blocks
Date: Mon, 22 May 2017 13:43:35 -0700 [thread overview]
Message-ID: <20170522204335.GM4519@birch.djwong.org> (raw)
In-Reply-To: <1ad226af-4b1b-18ca-274c-20a030ca4768@sandeen.net>
On Mon, May 22, 2017 at 03:06:40PM -0500, Eric Sandeen wrote:
> This structure copy was throwing unaligned access warnings on sparc64:
>
> Kernel unaligned access at TPC[1043c088] xfs_btree_visit_blocks+0x88/0xe0 [xfs]
>
> xfs_btree_copy_ptrs does a memcpy, which avoids it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Heh. :(
Looks ok to me...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 5392674..3a673ba 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4395,7 +4395,7 @@ struct xfs_btree_split_args {
> xfs_btree_readahead_ptr(cur, ptr, 1);
>
> /* save for the next iteration of the loop */
> - lptr = *ptr;
> + xfs_btree_copy_ptrs(cur, &lptr, ptr, 1);
> }
>
> /* for each buffer in the level */
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-05-22 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 15:48 [PATCH] xfs: fix unaligned access in xfs_btree_visit_blocks Eric Sandeen
2017-05-22 16:02 ` Eric Sandeen
2017-05-22 19:07 ` Christoph Hellwig
2017-05-22 19:40 ` Eric Sandeen
2017-05-22 20:06 ` [PATCH V2] " Eric Sandeen
2017-05-22 20:43 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522204335.GM4519@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).