From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix spurious spin_is_locked() assert failures on non-smp kernels
Date: Wed, 7 Jun 2017 07:54:54 -0400 [thread overview]
Message-ID: <20170607115454.GA62888@bfoster.bfoster> (raw)
In-Reply-To: <20170607112140.GA28606@infradead.org>
On Wed, Jun 07, 2017 at 04:21:40AM -0700, Christoph Hellwig wrote:
> On Wed, Jun 07, 2017 at 06:56:57AM -0400, Brian Foster wrote:
> > The 0-day kernel test robot reports assertion failures on
> > !CONFIG_SMP kernels due to failed spin_is_locked() checks. As it
> > turns out, spin_is_locked() is hardcoded to return zero on
> > !CONFIG_SMP kernels and so this function cannot be relied on to
> > verify spinlock state in this configuration.
> >
> > To avoid this problem, update the associated asserts to fail only
> > when CONFIG_SMP is enabled in the kernel. Note that this is not
> > necessary for one assert that expects a zero return from
> > spin_is_locked(). Update this assert anyways for consistency and
> > future proofing.
>
> Just switch to lockdep_assert_held instead of this mess..
Seems reasonable, I wasn't aware of that. What about the
!spin_is_locked() case? Do you want to drop it?
Brian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-07 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 10:56 [PATCH] xfs: fix spurious spin_is_locked() assert failures on non-smp kernels Brian Foster
2017-06-07 11:21 ` Christoph Hellwig
2017-06-07 11:54 ` Brian Foster [this message]
2017-06-07 13:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607115454.GA62888@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).