From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix spurious spin_is_locked() assert failures on non-smp kernels
Date: Wed, 7 Jun 2017 06:13:11 -0700 [thread overview]
Message-ID: <20170607131311.GA18098@infradead.org> (raw)
In-Reply-To: <20170607115454.GA62888@bfoster.bfoster>
On Wed, Jun 07, 2017 at 07:54:54AM -0400, Brian Foster wrote:
> > Just switch to lockdep_assert_held instead of this mess..
>
> Seems reasonable, I wasn't aware of that. What about the
> !spin_is_locked() case? Do you want to drop it?
Yes, I would just drop it.
prev parent reply other threads:[~2017-06-07 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 10:56 [PATCH] xfs: fix spurious spin_is_locked() assert failures on non-smp kernels Brian Foster
2017-06-07 11:21 ` Christoph Hellwig
2017-06-07 11:54 ` Brian Foster
2017-06-07 13:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607131311.GA18098@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).